Trim console output before processing it in console document by trancexpress · Pull Request #2462 · eclipse-platform/eclipse.platform

trancexpress · 2026-02-24T11:15:33Z

When processing large amounts of console output of a process, its possible that the Eclipse UI will freeze.
E.g. on Linux, very long lines (> 1 million symbols) result in such freezes.

Using the console limit preference doesn't help preventing this freeze, despite limitting the contents seen in the console.

This change adjusts IOConsolePartitioner.QueueProcessingJob.processPendingPartitions() to trim pending console output before setting this output in the console document, if a console limit is set in the Eclipse preferences.

See: #2283

trancexpress · 2026-02-24T11:16:23Z

 					applyStreamOutput(pendingCopy, sizeHint);
 				}
 				checkFinished();
 				checkBufferSize(); // needs partitions synchronized


Proper trimming is done here. The above change just reduces the output that will be processed by the document / underlying widget.

Copilot

Pull request overview

This PR aims to prevent Eclipse UI freezes when processing extremely large console output by trimming pending console output in IOConsolePartitioner.QueueProcessingJob.processPendingPartitions() before applying it to the console document, when a console limit (water marks) is configured.

Changes:

Adds logic in processPendingPartitions() to trim pending partitions based on the console highWaterMark before calling applyStreamOutput(...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-24T11:50:32Z

Test Results

54 files ±0 54 suites ±0 35m 44s ⏱️ +55s
4 546 tests ±0 4 523 ✅ ±0 23 💤 ±0 0 ❌ ±0
12 234 runs ±0 12 075 ✅ ±0 159 💤 ±0 0 ❌ ±0

Results for commit b3e136f. ± Comparison against base commit fce9709.

♻️ This comment has been updated with latest results.

trancexpress · 2026-02-24T14:00:17Z

Fails on Linux:

 org.eclipse.debug.tests.console.IOConsoleTests.testTrim -- Time elapsed: 0.180 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 
Expected string not found in console document. ==> expected: <0123456789> but was: <
012345678>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156)
	at org.eclipse.debug.tests.console.IOConsoleTestUtil.verifyContentByOffset(IOConsoleTestUtil.java:572)
	at org.eclipse.debug.tests.console.IOConsoleTests.testTrim(IOConsoleTests.java:718)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

 org.eclipse.debug.tests.console.IOConsoleFixedWidthTests.testTrim -- Time elapsed: 0.233 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 
Expected string not found in console document. ==> expected: <0123456789> but was: <
012345678>
	at org.eclipse.debug.tests.console.IOConsoleTestUtil.verifyContentByOffset(IOConsoleTestUtil.java:572)
	at org.eclipse.debug.tests.console.IOConsoleTests.testTrim(IOConsoleTests.java:718)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

 org.eclipse.debug.tests.console.ProcessConsoleManagerTests.testProcessConsoleLifecycle(TestInfo) -- Time elapsed: 0.084 s <<< FAILURE!
java.lang.AssertionError: 
[console has been added] 
Expected size: 1 but was: 3 in:
[org.eclipse.ui.console.IOConsole@2548368f,
    org.eclipse.ui.console.IOConsole@2a858f05,
    org.eclipse.debug.internal.ui.views.console.ProcessConsole@3946284c]
	at org.eclipse.debug.tests.console.ProcessConsoleManagerTests.testProcessConsoleLifecycle(ProcessConsoleManagerTests.java:88)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

trancexpress · 2026-02-24T15:16:40Z

Lets apply this one in a separate issue, its causing fails:

@@ -1203,6 +1240,8 @@ public class IOConsolePartitioner
                                        if (truncateToOffsetLineStart) {
                                                int cutoffLine = document.getLineOfOffset(truncateOffset);
                                                cutOffset = document.getLineOffset(cutoffLine);
+                                               // deal with case of one long line
+                                               cutOffset = Math.max(cutOffset, truncateOffset);
                                        }
                                        if (cutOffset >= length) {
                                                updateType = DocUpdateType.TRIM;

trancexpress · 2026-02-24T15:41:24Z

Fail on Linux is:

 org.eclipse.core.tests.resources.NatureTest.testBug297871 -- Time elapsed: 0.006 s <<< ERROR!
java.nio.file.FileAlreadyExistsException: /home/runner/work/eclipse.platform/eclipse.platform/resources/tests/org.eclipse.core.tests.resources/target/work/data/40050a949511001114069a35697b81a0/.project
	at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:94)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
	at java.base/sun.nio.fs.UnixFileSystem.copyFile(UnixFileSystem.java:668)
	at java.base/sun.nio.fs.UnixFileSystem.copy(UnixFileSystem.java:1075)
	at java.base/sun.nio.fs.UnixFileSystemProvider.copy(UnixFileSystemProvider.java:300)
	at java.base/java.nio.file.Files.copy(Files.java:1305)
	at org.eclipse.core.tests.resources.NatureTest.testBug297871(NatureTest.java:303)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

trancexpress · 2026-03-02T17:08:19Z

@iloveeclipse please check this one as well, it should solve the console UI freezes if the console limit is set (together with the line trim PR which you merged).

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

trancexpress · 2026-03-04T16:43:17Z

@iloveeclipse please review.

When processing large amounts of console output of a process, its possible that the Eclipse UI will freeze. E.g. on Linux, very long lines (> 1 million symbols) result in such freezes. Using the console limit preference doesn't help preventing this freeze, despite limitting the contents seen in the console. This change adjusts IOConsolePartitioner.QueueProcessingJob.processPendingPartitions() to trim pending console output before setting this output in the console document, if a console limit is set in the Eclipse preferences. See: eclipse-platform#2283

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

iloveeclipse

LGTM

trancexpress requested a review from iloveeclipse February 24, 2026 11:15

trancexpress commented Feb 24, 2026

View reviewed changes

Comment thread debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java Outdated

iloveeclipse requested a review from Copilot February 24, 2026 11:25

Copilot started reviewing on behalf of iloveeclipse February 24, 2026 11:26 View session

trancexpress mentioned this pull request Feb 24, 2026

Random UI freezes because of never ending IOConsolePartitioner...processPendingPartitions #2283

Closed

1 task

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Comment thread debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java Outdated

Comment thread debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java

trancexpress force-pushed the gh2283 branch from e098fdc to 4fa7573 Compare February 24, 2026 13:14

trancexpress force-pushed the gh2283 branch from 4fa7573 to 9b230a8 Compare February 24, 2026 15:17

trancexpress marked this pull request as ready for review February 24, 2026 15:22

trancexpress changed the title ~~Trim console output before processing it console document~~ Trim console output before processing it in console document Feb 27, 2026

trancexpress force-pushed the gh2283 branch 3 times, most recently from d7abd9c to 5c2fefa Compare March 2, 2026 17:05

iloveeclipse requested a review from Copilot March 2, 2026 17:08

Copilot started reviewing on behalf of iloveeclipse March 2, 2026 17:09 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Comment thread debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java

trancexpress commented Mar 2, 2026

View reviewed changes

Comment thread debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java Outdated

trancexpress force-pushed the gh2283 branch from 9f0981f to 683a8a7 Compare March 2, 2026 17:34

trancexpress force-pushed the gh2283 branch from 683a8a7 to b3e136f Compare March 8, 2026 16:21

iloveeclipse requested a review from Copilot March 12, 2026 16:10

Copilot started reviewing on behalf of iloveeclipse March 12, 2026 16:11 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

iloveeclipse approved these changes Mar 13, 2026

View reviewed changes

iloveeclipse merged commit 2776d6f into eclipse-platform:master Mar 13, 2026
22 checks passed

Conversation

trancexpress commented Feb 24, 2026

Uh oh!

trancexpress Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

trancexpress commented Feb 24, 2026

Uh oh!

trancexpress commented Feb 24, 2026

Uh oh!

trancexpress commented Feb 24, 2026

Uh oh!

trancexpress commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

trancexpress commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

iloveeclipse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Feb 24, 2026 •

edited

Loading